feat: migrate to different namespace #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajprakash00
added a commit
to rajprakash00/zulip-mobile
that referenced
this pull request
Feb 28, 2021
`Clipboard` in React Native core is deprecated [1]. Because of that warning errors are shown in console to use `@react-native-community/clipboard` which was recently migrated to `@react-native-clipboard/clipboard` [2]. So, use it. Also,this library has built-in Flow support, so we don't need to make our own libdef. [1]: https://reactnative.dev/docs/clipboard [2]: react-native-clipboard/clipboard#87 Signed-off-by: rajprakash00 <rajprakash1999@gmail.com>
rajprakash00
added a commit
to rajprakash00/zulip-mobile
that referenced
this pull request
May 7, 2021
`Clipboard` in React Native core is deprecated [1]. Because of that warning errors are shown in console to use `@react-native-community/clipboard` which was recently migrated to `@react-native-clipboard/clipboard` [2]. So, use it. Also,this library has built-in Flow support, so we don't need to make our own libdef. [1]: https://reactnative.dev/docs/clipboard [2]: react-native-clipboard/clipboard#87 Signed-off-by: rajprakash00 <rajprakash1999@gmail.com>
rajprakash00
added a commit
to rajprakash00/zulip-mobile
that referenced
this pull request
May 8, 2021
`Clipboard` in React Native core is deprecated [1]. Because of that warning errors are shown(whenever we try the `copy to clipboard` option to copy any message from message-view) in console to use`@react-native-community/clipboard` which was recently migrated to `@react-native-clipboard/clipboard` [2]. So, use it. Also,write our own custom libdef for this with proper definitions by taking notes from `@react-native-clipboard/clipboard/dist/Clipboard.d.ts`. [1]: https://reactnative.dev/docs/clipboard [2]: react-native-clipboard/clipboard#87 Signed-off-by: rajprakash00 <rajprakash1999@gmail.com>
chrisbobbe
added a commit
to chrisbobbe/zulip-mobile
that referenced
this pull request
Mar 10, 2022
`Clipboard` in RN core is deprecated; see warning at https://reactnative.dev/docs/clipboard Reportedly [1], we've been getting console warnings that we should use @react-native-community/clipboard instead of the RN-core module. Do basically that, except we use its new name, @react-native-clipboard/clipboard; see react-native-clipboard/clipboard#87 Put the types in a .js.flow file, rather than a libdef in `flow-typed/`, inspired by Greg's commit 007dea3. Supersedes: zulip#4502 Co-authored-by: rajprakash00 <rajprakash1999@gmail.com>
chrisbobbe
added a commit
to chrisbobbe/zulip-mobile
that referenced
this pull request
Mar 29, 2022
`Clipboard` in RN core is deprecated; see warning at https://reactnative.dev/docs/clipboard We've reportedly been getting console warnings that we should use @react-native-community/clipboard instead of the RN-core module. Do basically that, except we use its new name, @react-native-clipboard/clipboard; see react-native-clipboard/clipboard#87 Put the types in a .js.flow file, rather than a libdef in `flow-typed/`, inspired by Greg's commit 007dea3. Supersedes: zulip#4502 Co-authored-by: rajprakash00 <rajprakash1999@gmail.com>
chrisbobbe
added a commit
to chrisbobbe/zulip-mobile
that referenced
this pull request
Apr 5, 2022
`Clipboard` in RN core is deprecated; see warning at https://reactnative.dev/docs/clipboard We've reportedly been getting console warnings that we should use @react-native-community/clipboard instead of the RN-core module. Do basically that, except we use its new name, @react-native-clipboard/clipboard; see react-native-clipboard/clipboard#87 Put the types in a .js.flow file, rather than a libdef in `flow-typed/`, inspired by Greg's commit 007dea3. Supersedes: zulip#4502 Co-authored-by: rajprakash00 <rajprakash1999@gmail.com>
chrisbobbe
added a commit
to chrisbobbe/zulip-mobile
that referenced
this pull request
Apr 5, 2022
`Clipboard` in RN core is deprecated; see warning at https://reactnative.dev/docs/clipboard We've reportedly been getting console warnings that we should use @react-native-community/clipboard instead of the RN-core module. Do basically that, except we use its new name, @react-native-clipboard/clipboard; see react-native-clipboard/clipboard#87 Put the types in a .js.flow file, rather than a libdef in `flow-typed/`, inspired by Greg's commit 007dea3. Supersedes: zulip#4502 Co-authored-by: rajprakash00 <rajprakash1999@gmail.com>
chrisbobbe
added a commit
to chrisbobbe/zulip-mobile
that referenced
this pull request
Jan 26, 2023
`Clipboard` in RN core has been deprecated for a while, and in RN's v0.71 doc they finally mark it "removed": https://reactnative.dev/docs/clipboard We've reportedly (zulip#4502) been getting console warnings that we should use @react-native-community/clipboard instead of the RN-core module. Do basically that, except we use its new name, @react-native-clipboard/clipboard; see react-native-clipboard/clipboard#87 Supersedes: zulip#4502 Co-authored-by: rajprakash00 <rajprakash1999@gmail.com>
gnprice
pushed a commit
to chrisbobbe/zulip-mobile
that referenced
this pull request
Jan 26, 2023
`Clipboard` in RN core has been deprecated for a while, and in RN's v0.71 doc they finally mark it "removed": https://reactnative.dev/docs/clipboard We've reportedly (zulip#4502) been getting console warnings that we should use @react-native-community/clipboard instead of the RN-core module. Do basically that, except we use its new name, @react-native-clipboard/clipboard; see react-native-clipboard/clipboard#87 Supersedes: zulip#4502 Co-authored-by: rajprakash00 <rajprakash1999@gmail.com>
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
part of react-native-community/discussions-and-proposals#330
moving this package to
@react-native-clipboard/clipboardTest Plan