run-android arguments --variant and and --appIdSuffix ignored

[adrianso]

Environment

System:
OS: macOS 13.0.1
CPU: (8) arm64 Apple M1
Memory: 81.17 MB / 16.00 GB
Shell: 5.8.1 - /bin/zsh
Binaries:
Node: 18.13.0 - /var/folders/cn/pdlsf8zs1cg0d21d3125ws400000gn/T/yarn--1673839173668-0.21160869548811556/node
Yarn: 1.22.19 - /var/folders/cn/pdlsf8zs1cg0d21d3125ws400000gn/T/yarn--1673839173668-0.21160869548811556/yarn
npm: 8.19.3 - ~/Library/Caches/fnm_multishells/45421_1673835655313/bin/npm
Watchman: 2023.01.09.00 - /opt/homebrew/bin/watchman
Managers:
CocoaPods: Not Found
SDKs:
iOS SDK:
Platforms: DriverKit 22.2, iOS 16.2, macOS 13.1, tvOS 16.1, watchOS 9.1
Android SDK:
API Levels: 23, 28, 29, 30, 31, 32, 33
Build Tools: 28.0.3, 29.0.2, 29.0.3, 30.0.2, 30.0.3, 31.0.0, 31.0.0, 31.0.0, 31.0.0, 32.0.0, 32.0.0, 33.0.0, 33.0.0, 33.0.1
System Images: android-25 | Android Wear ARM EABI v7a, android-26 | ARM 64 v8a, android-27 | Google APIs ARM 64 v8a, android-30 | Google Play ARM 64 v8a, android-31 | Google Play ARM 64 v8a, android-33 | Google APIs ARM 64 v8a, android-33 | Google Play ARM 64 v8a
Android NDK: Not Found
IDEs:
Android Studio: 2021.3 AI-213.7172.25.2113.9123335
Xcode: 14.2/14C18 - /usr/bin/xcodebuild
Languages:
Java: 11.0.17 - /usr/bin/javac
npmPackages:
@react-native-community/cli: Not Found
react: 18.2.0 => 18.2.0
react-native: 0.71.0 => 0.71.0
react-native-macos: Not Found
npmGlobalPackages:
react-native: Not Found

Description

When I run the following command, the variant and appIdSuffix arguments are ignored.
yarn react-native run-android --variant devDebug --appIdSuffix dev

I get the following error

error Failed to install the app. Make sure you have the Android development environment set up: https://reactnative.dev/docs/environment-setup.
Error: Command failed: ./gradlew app:installDebug -PreactNativeDevServerPort=8081

FAILURE: Build failed with an exception.

* What went wrong:
Task 'installDebug' not found in project ':app'.

This was working correct in the previous React Native release 0.70.4.

Reproducible Demo

• Create a new project with npx react-native init RN071
• Start an Android emulator
• Run yarn react-native run-android --variant devDebug --appIdSuffix dev
• Verify that the incorrect command ./gradlew app:installDebug -PreactNativeDevServerPort=8081 is run

[TMisiukiewicz]

Hi @adrianso , thanks for reporting - gonna take a look at this one 🙂

[TMisiukiewicz]

Unfortunately cannot reproduce it 😞

System:
    OS: macOS 13.0.1
    CPU: (8) arm64 Apple M1 Pro
    Memory: 216.23 MB / 32.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 16.19.0 - ~/.nvm/versions/node/v16.19.0/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 8.19.3 - ~/.nvm/versions/node/v16.19.0/bin/npm
    Watchman: 2022.10.31.00 - /opt/homebrew/bin/watchman
  Managers:
    CocoaPods: Not Found
  SDKs:
    iOS SDK:
      Platforms: DriverKit 22.1, iOS 16.1, macOS 13.0, tvOS 16.1, watchOS 9.1
    Android SDK: Not Found
  IDEs:
    Android Studio: Dolphin 2021.3.1 Patch 1 Dolphin 2021.3.1 Patch 1
    Xcode: 14.1/14B47b - /usr/bin/xcodebuild
  Languages:
    Java: 11.0.17 - /usr/bin/javac
  npmPackages:
    @react-native-community/cli: Not Found
    react: 18.2.0 => 18.2.0 
    react-native: 0.71.0 => 0.71.0 
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

> Task :app:installDebug
Installing APK 'app-debug.apk' on 'Pixel_3a_API_33_arm64-v8a(AVD) - 13' for :app:debug
Installed on 1 device.

BUILD SUCCESSFUL in 3s

@szymonrybczak @adamTrz could you give a hand here and try reproducing it?

[szymonrybczak]

Hey @adrianso, as the docs says --variant option is deprecated, please try the --mode option, also make sure that you have added the app's build variants to the android/app/build.gradle.

[adrianso]

Hi @TMisiukiewicz, thanks for looking into this.
You have actually successfully reproduced the issue. You just didn't realise it.

See the line below.
> Task :app:installDebug

The issue with the task installDebug. If I pass the variant parameter, the task to run should be
> Task :app:install<variant>Debug

To illustrate the problem, I have a created a simple repo to reproduce the problem.
https://github.com/adrianso/react-native-cli-variant-issue

To reproduce the issue:

• Check out the repo
• yarn install
• yarn android-variant
• See the compilation fails with the error Error: Command failed: ./gradlew app:installDebug -PreactNativeDevServerPort=8081

Let me know if you need anything else!

[adrianso]

Hi @szymonrybczak, thanks for looking into the issue!

I had a look at the doc that you mentioned, but that's for the wrong command.

The issue I am encountering is with runAndroid (See doc here). And the --variant parameter is supported for runAndroid.

Can you please take another look?

[adamTrz]

Hi @adrianso
Could you please try to run yarn react-native run-android --mode devDebug --appIdSuffix dev and see how it goes?

[adrianso]

@adamTrz Beautiful. It works now! Thanks for your help!

[manjuy124]

@adamTrz thank you. Its worked!