-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: adjust run instruction based on the user platform #1285
chore: adjust run instruction based on the user platform #1285
Conversation
CI fail looks unrelated to the changes performed within this PR (similar issue happen in #1280 (comment)): |
c57240e
to
5fb5632
Compare
Mind sending some screenshots on how the end result looks now (at least on one platform)? |
Preview@thymikee It looks like I had to remove one indentation from the nested in conditionals instructions: |
Let's address this then |
@asklar Is it possible to create the short URLs for both platforms, leading to Getting Started pages? For example:
|
@Simek I've created ReactNativeMacOS, ReactNativeGuideWindows and ReactNativeGuideMacOS |
4451e83
to
5db47f3
Compare
@thymikee I have changed the color of Windows instructions header to |
Thank you @Simek 🚀 ! |
Summary:
This PR adjust the run instructions printed at the end of
init
command run which now should show only valid targets for the user platform. I have also updated the links for the desktop forks from MS to lead exactly to platform specific guides.iOS
andmacOS
instructions will be only visible ondarwin
Windows
instructions will be only visible onwin32
Test Plan:
I was trying to test the
init
locally using Contributing guide, but I have experienced problems and issues after publishingreact-native
master locally.One of many problems which leads to
init
termination:Please let me know is there any other way to test the
init
command without publishingreact-native
locally.