Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: interactive mode for selecting mode and scheme for iOS #1811

Merged

Conversation

TMisiukiewicz
Copy link
Collaborator

Summary:

Interactively select configuration and scheme for run-ios and build-ios

Screen.Recording.2023-01-26.at.15.15.26.mov

Test Plan:

Use run-ios --explicit command - select desired configuration and scheme. If there is only one configuration/scheme, the prompt will be ignored. You can create additional schemes and configurations by opening the project in Xcode.

@TMisiukiewicz
Copy link
Collaborator Author

one thing that comes to my mind is to integrate it in the future with device selection prompt which was merged lately. WDYT?

@thymikee
Copy link
Member

This is looking slick! Thanks for putting it behind the flag, let's experiment with it first. Regarding the flag name, I'd go with --interactive instead of --explicit, which is used in many CLI tools out there, with --no-interactive mode targeted for CI platforms where prompts don't make sense.

@thymikee
Copy link
Member

I'd wait for this to merge after the #1744

@adamTrz
Copy link
Collaborator

adamTrz commented Jan 26, 2023

I'd wait for this to merge after the #1744

@thymikee - it's is already merged 😉

@adamTrz
Copy link
Collaborator

adamTrz commented Jan 26, 2023

one thing that comes to my mind is to integrate it in the future with device selection prompt which was merged lately. WDYT?

100% agree. And renaming to --interactive would make even more sense there I would say.

@TMisiukiewicz TMisiukiewicz force-pushed the feat/build-interactive-mode branch from f71d4f1 to 22cac0a Compare January 27, 2023 12:01
@TMisiukiewicz
Copy link
Collaborator Author

@thymikee @adamTrz thanks for your responses, could you re-check the updates when you have a moment please?

@adamTrz
Copy link
Collaborator

adamTrz commented Jan 27, 2023

@thymikee @adamTrz thanks for your responses, could you re-check the updates when you have a moment please?

Lookin' good!

But please fix tests 🙂

@TMisiukiewicz TMisiukiewicz force-pushed the feat/build-interactive-mode branch 2 times, most recently from 207d254 to 3607225 Compare January 30, 2023 10:49
@TMisiukiewicz
Copy link
Collaborator Author

all the tests are green when i run it locally, so i assume it will be fixed once #1804 gets merged, let's wait and see if i am correct 😄

@TMisiukiewicz TMisiukiewicz force-pushed the feat/build-interactive-mode branch from 3607225 to e24533c Compare February 3, 2023 10:40
@TMisiukiewicz TMisiukiewicz force-pushed the feat/build-interactive-mode branch from e24533c to 2c36c49 Compare February 3, 2023 11:08
@adamTrz adamTrz merged commit 1e54606 into react-native-community:main Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants