Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: interactive mode for android #1815

Merged

Conversation

adamTrz
Copy link
Collaborator

@adamTrz adamTrz commented Feb 3, 2023

Summary:

Added interactive mode for Android build and run commands.

Screenshot 2023-02-03 at 15 10 22

Screenshot 2023-02-03 at 16 17 25

Test Plan:

Checkout branch and run run/build-android --interactive

@adamTrz adamTrz requested a review from thymikee as a code owner February 3, 2023 15:18
description: string;
};

const parseTasksFromGradleFile = (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add tests for those utils please :)

Copy link
Member

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool stuff :)

adamTrz and others added 2 commits February 3, 2023 17:41
…oidTasks.ts

Co-authored-by: Nicola Corti <corti.nico@gmail.com>
adamTrz and others added 3 commits February 6, 2023 11:41
Co-authored-by: Szymon Rybczak <szymon.rybczak@gmail.com>
…ractive-mode' of github.com:adamTrz/cli into feat-android-interactive-mode
@adamTrz adamTrz merged commit a8ff4ff into react-native-community:main Feb 10, 2023
@adamTrz adamTrz deleted the feat-android-interactive-mode branch February 10, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants