fix: Do not have empty AUTOLINKED_LIBRARIES
#2306
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When working on TM CXX Autolinking I forgot to return the value here, and this results in
AUTOLINKED_LIBRARIES
CMake variable being empty. Effectively we're not linking against anything then, which is causing build failures in OSS.See:
appmodules
facebook/react-native#43145Test Plan:
Tested against RNTA reporducer by @tido64
Checklist