Configure nsurl session #165
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As pointed out by @rjerue in #166, the Android implementation allows for setting the HTTP client factory with a static method. The way I see it, that is similar to the alternative approach listed in this RFC. I believe it's beneficial that the customization mechanism is similar across platforms. Thus, perhaps that is the best approach on iOS as well. Curious to hear what your thoughts are! |
|
I think the discussion of this would be best on a PR to the main repo with the actual code. I think this since this is focused on a specific change it will be easier for you to receive feedback that way than here on this repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposal addresses how the HTTP session configuration of
RCTHTTPRequestHandlercan be handled.