Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard-friendly List Virtualization Behavior #335

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
179 changes: 179 additions & 0 deletions proposals/0006-Keyboard-Friendly-Virtualization.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,179 @@
---
title: "RFC0006: Keyboard-friendly List Virtualization Behavior"
author: Nick Gerleman
date: February 2021
---

# RFC0006: Keyboard-friendly List Virtualization Behavior

## Summary

VirtualizedList virtualizes away items based on proximity to the lists viewport,
without consideration for other inputs such as focus or selection. This
strategy limits the ability to correctly implement some common keyboard
interactions. This especially impacts desktop platforms (react-native-web,
react-native-windows, react-native-macos), but also impacts the tablet with
keyboard form-factor on iPadOS/Android.

This proposal outlines these issues, proposing a set of behavior changes and new
APIs to address them. It does not address concrete implementation.

## Basic example

```jsx
<FlatList
{...otherProps}
keepAreasRealized={{
focused: false,
home: [true, {windowSize: 1}],
}}
/>
```

## Motivation

Keyboard users expect to be able to navigate between between views inside of a
list via tab-loop or arrow keys. A component with focus may move out of
visibility by panning or scrolling a parent surface. The focused component may
be virtualized away after leaving visibility.

The removal of this native component disrupts state needed to move focus/selection.

## Detailed design

### Realization windows

Focus may be moved by the native UI framework without waiting on a new component to be rendered. This forces us to
prevent virtualization (keep realized) any components which focus may be moved
to. We may see additional navigation after the initial focus change, unblocked
on the rendering of new components. This necessitates a chain of additional
realized components.

Common keyboarding scenarios should ideally work by default, without having to change
settings. Some of these scenarios include

1. Navigating from one child component of a rendered item to another
1. Arrowing between focused items
1. Shifting focus from currently focused item via page up/down
1. Shifting focus to first/last item via home/end keys

`VirtualizedList` has enough internal knowledge to transparently support these
scenarios. This can be accomplished by adding three **"realization windows"**:
1. **"focused"** Realize cells around a cell with active focus. Can be
tracked by listening to bubbling onFocus in the default `CellRendererComponent`.
NickGerleman marked this conversation as resolved.
Show resolved Hide resolved
1. **"home"** The area at the beginning of the list (for home key).
1. **"end"** The area at the end of the list (for end key).

> Note that Apple devices have "fn + left" or "fn + right" which behave similarly
> to home/end, but do not move selection in apps like Finder.

The above scenarios are not exhaustive. E.g. we may want to keep a *selected*
item realized that is not *focused*. These scenarios may require additional APIs
allowing external users greater control over realization behavior. These could
potentially be exposed in the future as dynamic/user-controllable realization
windows, or separate high-level APIs.

### Endpoint-specific default behaviors

VirtualizedList should be keyboard-friendly by default on desktop platforms as
they are oriented towards usage of a physical keyboard. This additional
realization is not free however, increasing memory usage to retain additional
cells. This tradeoff may not make sense for mobile.

This leads to desired behavior of:
- **Keep FlatList focus-safe on desktop:** Realization windows needed for
correct keyboard navigation should be enabled by default.
- **Keep FlatList memory usage steady on mobile:** New realization windows
are opt-in where not pay to play.

The full matrix of behaviors is described in the *API Reference* below.

Endpoint detection is generally performed via `Platform` APIs, such as
`Platform.isTV()` or `Platform.isPad()`. This change would add a
`Platform.isDesktop()` endpoint query to allow desktop-specific behavior.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this! I suggest this in facebook/react-native#29937 but that never was completed.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Android also has this, withPlatformConstants.constants.uiMode being 'desk' for desktop.


### New VirtualizedList props

Properties should be added to VirtualizedList (and FlatList/SectionList) to
allow optimizing for app-specific needs. This can be exposed as a
`RealizationWindowConfig`, describing the size and enablement of predefined
realization windows. This API could be expanded in the future to allow
dynamically controlled realization behaviors.


### API reference

```tsx
/**
* Allows enabling or disabling an area for realization, optionally overriding
* its window size.
*/
export type RealizationWindow =
| boolean
| [boolean, {windowSize?: number}];
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this might be too much unnecessary configuration being able to adjust each windowSize. Any reason we'd ever want this to not be 1?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default windowSize for the viewport is fairly large, rendering a whole 10 screens above and below. This is a pretty aggressive amount of pre-rendering. It seems like existing setup optimizes for avoiding blanking on fast movement/interaction over memory consumption.

The realization areas have the potential for similar issues. A conceivable user scenario is to quickly tab between items taller than a viewport. Items would possibly not be realized in time for the keyboard interaction. Keeping a larger window fixes this, but a viewport's worth of native controls could be a non-trivial amount of memory, or cause jank due to excessive native renders.

The right amount of prerendering here seems to depend on scenario. I think we can pick something sane as a default, but am not confident a specific size would work well in all scenarios

I think there might be some alternate APIs to make configuration cleaner, and want to play around with that. I think configurability would be useful here in a general-sense though.


/**
* Determines what areas of the list to keep realized. Enabling realization may
* be required for correct behavior when focus is out of viewport, but may also
* increase memory usage.
*/
export type RealizationWindowConfig = {
/**
* Keeps the area around the currently focused item realized.
* - Enabled by default on all platforms
*
* To function with a non-default (CellRendererComponent)[
* https://reactnative.dev/docs/virtualizedlist#cellrenderercomponent],
* `onFocus` and `onBlur` props must be supported.
*
* Defaults to the (VirtualizedList windowSize)[
* https://reactnative.dev/docs/virtualizedlist#windowsize]
*/
focused?: RealizationWindow;

/**
* Keeps the beginning area of the list realized. Useful to allow instantly
* shifting focus to the first item (e.g. via Home key).
* - Disabled by default on all platforms
* - Should be enabled by default on desktop if FlatList begins transparently
* supporting home/end focus.
*
* Defaults to **1/4th** the (VirtualizedList windowSize)[
* https://reactnative.dev/docs/virtualizedlist#windowsize]
*/
home?: RealizationWindow;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should call this start instead. The "home" terminology doesn't really fit well with our other APIs, and "start" is clear.


/**
* Keeps the end area of the list realized. Useful to allow instantly
* shifting focus to the first item (e.g. via End key).
* - Disabled by default on all platforms
* - Should be enabled by default on desktop if FlatList begins transparently
* supporting home/end focus.
*
* Defaults to **1/4th** the (VirtualizedList windowSize)[
* https://reactnative.dev/docs/virtualizedlist#windowsize]
*/
end?: RealizationWindow;

// Potential to add additional props for different (or dynamic) realization
// areas
}

/**
* VirtualizedList (and FlatList/SectionList) component properties
*/
export type VirtualizedListProps = {
...

/**
* Enables realization of different areas of the VirtualizedList
*/
keepAreasRealized?: RealizationWindowConfig;
}
```

## Drawbacks

Apart from implementation complexity and risk, the greatest drawback to
additional realization is memory consumption. This motivates configurability to
mitigate impact.