-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CMake 3.22.1 to the container #192
Conversation
So I would like to get this released inside |
probably something similar to what we do in core:
any specific reason why you don't want the other changes? |
Hey @gengjiawen, seems like GH Actions are failing to publish to Docker Hub due to wrong username & password. Could you take a look: https://github.com/react-native-community/docker-android/actions/runs/3940753863 |
I reset password due to circleci leak, I forgot update here. I will update it later. On a travel now. |
Thanks for the update 👍 Please let us know as soon as this is done as this is currently blocking a next release |
@gengjiawen just to be clear, are we talking hours or days or weeks of travel? just asking 'cause we need to determine if we have to go for 0.71.1 or 0.71.2 for this fix 😅 |
Already fixed. Also retriggered the CI |
It’s a long train travel for Chinese new year,sorry for the delay. Me and satina are the admin of docker image. Do you want to join the team ? I can setup it later. |
ok, thanks! and yeah I think that it'd be good to get at least @cortinico in the group of admins for the docker image (who is satina?) |
|
ah good to know, thanks! |
@cortinico If you are interested, please email me your docker hub account or paste it here. |
I'm adding CMake 3.22.1 to the container as I believe that's the fix for:
facebook/react-native#35828
I'm still validating my assumptions, but regardless of this, having the newer version of CMake in the container will be needed as AGP 7.4 defaults to CMake 3.22 so without it installed, it will download it at buildtime.
Here I've take a backward-compat approach by keeping both the old and the new CMake installed as for template tests on AGP 7.3, the build still needs CMake 3.18