Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CMake 3.22.1 to the container #192

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Add CMake 3.22.1 to the container #192

merged 1 commit into from
Jan 17, 2023

Conversation

cortinico
Copy link
Member

I'm adding CMake 3.22.1 to the container as I believe that's the fix for:
facebook/react-native#35828

I'm still validating my assumptions, but regardless of this, having the newer version of CMake in the container will be needed as AGP 7.4 defaults to CMake 3.22 so without it installed, it will download it at buildtime.

Here I've take a backward-compat approach by keeping both the old and the new CMake installed as for template tests on AGP 7.3, the build still needs CMake 3.18

@gengjiawen gengjiawen merged commit 97ae8c1 into master Jan 17, 2023
@gengjiawen gengjiawen deleted the nc/cmake22 branch January 17, 2023 13:31
@cortinico
Copy link
Member Author

So I would like to get this released inside v6.2 but without the 2 commits we have on main for the Node bump (i.e. this commit needs to sit on top of v6.1. What's the preferred approach? Should I create a branch?

@kelset
Copy link
Member

kelset commented Jan 17, 2023

So I would like to get this released inside v6.2 but without the 2 commits we have on main for the Node bump (i.e. this commit needs to sit on top of v6.1. What's the preferred approach? Should I create a branch?

probably something similar to what we do in core:

  • create a 6.x branch from the commit you want
  • cherry pick this fix
  • release 6.2 from there
  • in main, bump to 7.x

any specific reason why you don't want the other changes?

cortinico added a commit that referenced this pull request Jan 17, 2023
@cortinico
Copy link
Member Author

Hey @gengjiawen, seems like GH Actions are failing to publish to Docker Hub due to wrong username & password. Could you take a look: https://github.com/react-native-community/docker-android/actions/runs/3940753863

@gengjiawen
Copy link
Member

Hey @gengjiawen, seems like GH Actions are failing to publish to Docker Hub due to wrong username & password. Could you take a look: https://github.com/react-native-community/docker-android/actions/runs/3940753863

I reset password due to circleci leak, I forgot update here. I will update it later. On a travel now.

@cortinico
Copy link
Member Author

I reset password due to circleci leak, I forgot update here. I will update it later. On a travel now.

Thanks for the update 👍 Please let us know as soon as this is done as this is currently blocking a next release

@kelset
Copy link
Member

kelset commented Jan 18, 2023

@gengjiawen just to be clear, are we talking hours or days or weeks of travel? just asking 'cause we need to determine if we have to go for 0.71.1 or 0.71.2 for this fix 😅

@gengjiawen
Copy link
Member

@gengjiawen just to be clear, are we talking hours or days or weeks of travel? just asking 'cause we need to determine if we have to go for 0.71.1 or 0.71.2 for this fix 😅

Already fixed. Also retriggered the CI

@gengjiawen
Copy link
Member

It’s a long train travel for Chinese new year,sorry for the delay. Me and satina are the admin of docker image. Do you want to join the team ? I can setup it later.

@kelset
Copy link
Member

kelset commented Jan 18, 2023

ok, thanks! and yeah I think that it'd be good to get at least @cortinico in the group of admins for the docker image (who is satina?)

@gengjiawen
Copy link
Member

ok, thanks! and yeah I think that it'd be good to get at least @cortinico in the group of admins for the docker image (who is satina?)

https://github.com/satya164

@kelset
Copy link
Member

kelset commented Jan 18, 2023

ah good to know, thanks!

@gengjiawen
Copy link
Member

gengjiawen commented Jan 29, 2023

@cortinico If you are interested, please email me your docker hub account or paste it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants