Add git config --global --add safe.directory '*'
#228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cortinico
force-pushed
the
nc/git-safe-dir
branch
from
889efd4 to
2f9d9eb
Compare
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Jul 1, 2024
…s inside Docker Summary: Following up to cipolleschi's work, it turns out that me setting this command inside the docker file for React Android is unneffective: react-native-community/docker-android#228 The reason is that the user executing is different (1001 for the Dockerfile, while GHA executes as root 1000). So we need to set this, otherwise the nightlies will be invoked with the `-TEMP` prefix: Changelog: [Internal] [Changed] - Setup `git config --global --add safe.directory '*'` when running jobs inside Docker Differential Revision: D59223862
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Jul 1, 2024
…s inside Docker (#45231) Summary: Pull Request resolved: #45231 Following up to cipolleschi's work, it turns out that me setting this command inside the docker file for React Android is unneffective: react-native-community/docker-android#228 The reason is that the user executing is different (1001 for the Dockerfile, while GHA executes as root 1000). So we need to set this, otherwise the nightlies will be invoked with the `-TEMP` prefix: Changelog: [Internal] [Changed] - Setup `git config --global --add safe.directory '*'` when running jobs inside Docker Reviewed By: blakef Differential Revision: D59223862 fbshipit-source-id: 26674fc8cdaebf6687407072cc4e4f5c38246845
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we're moving over to GHA we're seeing failures that require us to specify which are the git safe directory. I'm setting them as
*in the global config to override those failures