Skip to content

feat: use C api from Swift #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2025
Merged

feat: use C api from Swift #13

merged 1 commit into from
Mar 4, 2025

Conversation

okwasniewski
Copy link
Collaborator

@okwasniewski okwasniewski commented Mar 3, 2025 •
edited
Loading

This PR is a follow up after: facebook/react-native#49489

  1. Uses C API for Swift
  2. Removes old architecture classes
  3. Adds bunch of #ifdef __cplusplus so Swift is happy

CleanShot 2025-03-03 at 13 14 45@2x

We need still need this PR: facebook/react-native#49781 Merged

@okwasniewski okwasniewski requested review from Kudo and cipolleschi March 4, 2025 08:43
@okwasniewski okwasniewski merged commit 98bde6b into main Mar 4, 2025
@okwasniewski okwasniewski deleted the feat/c-api branch March 4, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kudo Kudo Kudo approved these changes

@cipolleschi cipolleschi Awaiting requested review from cipolleschi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@okwasniewski @Kudo