Update for RN 0.60 #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @Kudo this looks good, the only question is if we really need that |
|
The .gitignore is not necessary and removed. |
|
Looks ok, will just wait for CI to finish and then merge |
|
CI weirdly kicked to my CI fork but is pass anyway. |
kmagiera
approved these changes
Apr 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer RN manages JSC by node dependency.
facebook/react-native#24276
Integrate and update JSC would be easier than before.
However, in the PR comments there are still some enhancements could be done.
packagingOptions.pickFirstto exclude them.For RN 0.58 and before, since it was built by gcc.
These is no libc++_shared.so but libgnustl_shared.so.
For jsc-android side, provide an android-jsc-cppruntime.aar for user to add libc++_shared.so.