Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: quote cache keys that start with special characters #143

Merged
merged 1 commit into from
Feb 27, 2022

Conversation

fotos
Copy link
Collaborator

@fotos fotos commented Feb 26, 2022

Description

Quick follow up on #142 which broke the build.

Added single quotes around cache keys that start with special characters such as {{.

Fixes:

circleci config pack src/ > packed-orb.yml

Error: Failed trying to marshal the tree to YAML : yaml: line 22: did not find expected '-' indicator

Tested with:

➜  circleci config pack src > packed-orb.yml
➜  circleci orb validate packed-orb.yml
Orb at `packed-orb.yml` is valid.

Hopefully this does the trick. 🤞 Unfortunately I have no way to actually test it.

@fotos
Copy link
Collaborator Author

fotos commented Feb 26, 2022

By the way, I think the CircleCI workflow doesn't run for forked pull requests.

There is a setting in CircleCI project settings:

build-forked-pull-requests

Maybe it should be enabled? If the pack job run it would have caught the syntax error before merging.

@cortinico cortinico merged commit 6630413 into react-native-community:master Feb 27, 2022
@react-native-community-bot
Copy link
Collaborator

🎉 This PR is included in version 6.8.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@fotos fotos deleted the fix-yaml-parsing branch February 27, 2022 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants