Skip to content

Commit

Permalink
feat: update to react-native@0.70.4 (#308)
Browse files Browse the repository at this point in the history 
* feat: update to react-native@0.70.4

* fix: fix project.pbxproj
  • Loading branch information
@YutaSugimura
YutaSugimura authored Oct 27, 2022
1 parent e43e5b7 commit 07b4d73
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
6 changes: 2 additions & 4 deletions template/ios/HelloWorld.xcodeproj/project.pbxproj
View file
Original file line number Diff line number Diff line change
Expand Up @@ -562,7 +562,7 @@
COPY_PHASE_STRIP = NO;
ENABLE_STRICT_OBJC_MSGSEND = YES;
ENABLE_TESTABILITY = YES;
"EXCLUDED_ARCHS[sdk=iphonesimulator*]" = i386;
"EXCLUDED_ARCHS[sdk=iphonesimulator*]" = ”;

This comment has been minimized.

Sign in to view

Copy link
@mfazekas

mfazekas Oct 27, 2022

Contributor

This is incorrect, and causes error on pod install:

% pod install

Analyzing dependencies
Traceback (most recent call last):

.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/nanaimo-0.3.0/lib/nanaimo/reader.rb:284:in `raise_parser_error': [!] Invalid character "\\xE2" in unquoted string (Nanaimo::Reader::ParseError)
   #  -------------------------------------------
   #                            ENABLE_STRICT_OBJC_MSGSEND = YES;
   #                            ENABLE_TESTABILITY = YES;
565>                            "EXCLUDED_ARCHS[sdk=iphonesimulator*]" = ”;
                                                                         ^
   #                            GCC_C_LANGUAGE_STANDARD = gnu99;
   #                            GCC_DYNAMIC_NO_PIC = NO;
   #  -------------------------------------------

This comment has been minimized.

Sign in to view

Copy link
@emin93

emin93 Oct 27, 2022

Member

Good catch, I missed that!
GCC_C_LANGUAGE_STANDARD = gnu99;
GCC_DYNAMIC_NO_PIC = NO;
GCC_NO_COMMON_BLOCKS = YES;
Expand Down Expand Up @@ -596,7 +596,6 @@
"-DFOLLY_MOBILE=1",
"-DFOLLY_USE_LIBCPP=1",
);
REACT_NATIVE_PATH = "${PODS_ROOT}/../../node_modules/react-native";
SDKROOT = iphoneos;
};
name = Debug;
Expand Down Expand Up @@ -634,7 +633,7 @@
COPY_PHASE_STRIP = YES;
ENABLE_NS_ASSERTIONS = NO;
ENABLE_STRICT_OBJC_MSGSEND = YES;
"EXCLUDED_ARCHS[sdk=iphonesimulator*]" = i386;
"EXCLUDED_ARCHS[sdk=iphonesimulator*]" = "";
GCC_C_LANGUAGE_STANDARD = gnu99;
GCC_NO_COMMON_BLOCKS = YES;
GCC_WARN_64_TO_32_BIT_CONVERSION = YES;
Expand All @@ -660,7 +659,6 @@
"-DFOLLY_MOBILE=1",
"-DFOLLY_USE_LIBCPP=1",
);
REACT_NATIVE_PATH = "${PODS_ROOT}/../../node_modules/react-native";
SDKROOT = iphoneos;
VALIDATE_PRODUCT = YES;
};
Expand Down
4 changes: 2 additions & 2 deletions template/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
},
"dependencies": {
"react": "18.1.0",
"react-native": "0.70.3"
"react-native": "0.70.4"
},
"devDependencies": {
"@babel/core": "^7.12.9",
Expand All @@ -20,7 +20,7 @@
"@tsconfig/react-native": "^2.0.2",
"@types/jest": "^26.0.23",
"@types/react": "^18.0.21",
"@types/react-native": "^0.70.4",
"@types/react-native": "^0.70.6",
"@types/react-test-renderer": "^18.0.0",
"@typescript-eslint/eslint-plugin": "^5.37.0",
"@typescript-eslint/parser": "^5.37.0",
Expand Down

0 comments on commit 07b4d73

Please sign in to comment.