New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix irregular indent in app/build.gradle #159

Closed

nacam403 wants to merge 1 commit into react-native-community:master from nacam403:fix-app-build-gradle-indent

nacam403 commented Sep 5, 2020

Summary

fix irregular indent in app/build.gradle

Test Plan

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS	Implemented
Android	✅

Checklist

I have tested this on a device and a simulator
I added the documentation in README.md
I mentioned this change in CHANGELOG.md
I updated the typed files (TS and Flow)
I added a sample use of the API in the example project (example/App.js)


          fix irregular indent

7e48e77

nacam403 requested review from emin93 and radko93 as code owners

September 5, 2020 08:16

Collaborator

radko93 commented Sep 5, 2020

Hi, is this the same in the original RN template?

Author

nacam403 commented Sep 5, 2020

Yes. I confirmed it just now.
https://github.com/facebook/react-native/blob/902611f14837752353e919dd1740812ec7260fb8/template/android/app/build.gradle#L191

Author

nacam403 commented Sep 6, 2020

I created a PR in RN repo.
facebook/react-native#29871

So, this PR (PR in react-native-template-typescript repo) may be closed. Thank you for your suggestion.

radko93 closed this

nacam403 deleted the fix-app-build-gradle-indent branch

September 7, 2020 07:36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet