Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some comments on 62 #107

Merged
merged 4 commits into from
Dec 18, 2019
Merged

some comments on 62 #107

merged 4 commits into from
Dec 18, 2019

Conversation

pvinis
Copy link
Member

@pvinis pvinis commented Dec 18, 2019

Summary

Test Plan

What are the steps to reproduce?

Checklist

  • I tested this thoroughly
  • I added the documentation in README.md (if needed)

@pvinis pvinis requested a review from lucasbento as a code owner December 18, 2019 22:11
@pvinis pvinis merged commit d15f413 into master Dec 18, 2019
@@ -1,4 +1,5 @@
const versions = ['0.61', '0.60', '0.59', '0.58', '0.57']
// this line HAAAAAAAAS to go
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this comment has to be an issue, not a comment.

Why does this line has to go? what does it need to be replaced with?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed, I just quickly made it there. I'll add it to the rework issue.

I was trying to add some comment and links etc for 62 and I forgot to add it here, and they would not show up. I want to make this part go away. if there is a comment or link or whatever for a release, it should be shown without the need for manual addition in this file and list, you know?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#108
the second point is touching this part, so this comment is now not needed I guess, but we can leave it as a reminder to rework it soon 😁 I started a branch but on holidays it's been slow.

@pvinis pvinis deleted the add-62 branch March 10, 2020 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants