feat: move AppNameWarning to DiffViewer #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvinis
approved these changes
Jan 2, 2020
lucasbento
requested changes
Jan 2, 2020
There was a problem hiding this comment.
This looks really good, thanks for the contribution!
A few points that I would like to change:
- There needs to be a space between
Useful contentsection and the app name info alert to keep consistency; - I strongly recommend to use the Markdown component to show the stuff between ``, it easier to look at;
- How about changing the message to
Keep in mind thatRnDiffAppandrndiffappare placeholders and, when upgrading, you should replace them with your actual project's name.?
|
@pvinis @lucasbento I've made the changes as suggested.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is part of #113
UsefulContentSection of DiffViewer (will only be displayed once diff is rendered)UsefulContentwidthwarningtoinfoNOTE:
semver7.x threw an error when I was working on this locally, so I had to changesemverback to6.3.0I'll add the comment about being able to change the AppName once #111 is merged :)
Test Plan
What are the steps to reproduce?
Checklist