Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show comments in the diff #18

Merged
merged 19 commits into from
Jun 12, 2019
Merged

Show comments in the diff #18

merged 19 commits into from
Jun 12, 2019

Conversation

lucasbento
Copy link
Member

@lucasbento lucasbento commented Jun 8, 2019

Summary

This PR adds the ability to show comments in the diff, the comments are provided by a file under ./src/releases. Related to #10.

Test Plan

Run the app locally and select 0.60.0.rc-0 as the destination version.


image


image

@lucasbento lucasbento requested a review from pvinis June 8, 2019 15:19
@lucasbento lucasbento changed the title feat: add comments in the diff Show comments in the diff Jun 8, 2019
@kelset kelset mentioned this pull request Jun 8, 2019
7 tasks
@pvinis
Copy link
Member

pvinis commented Jun 8, 2019

🤣 I looooove those comments! I don't even need to talk about the second one!

@kelset
Copy link
Member

kelset commented Jun 12, 2019

So the only blocker here for now is the copy for the comments?

@lucasbento
Copy link
Member Author

@kelset: I'm waiting for @pvinis to approve the code so we can merge it, before merging it I'll remove the current comments, right now they are here just to illustrate how to add them.

Copy link
Member

@pvinis pvinis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@kelset
Copy link
Member

kelset commented Jun 12, 2019

Gotcha - I guess we want to have that in the readme right? Because these comments will live in this repo

@pvinis
Copy link
Member

pvinis commented Jun 12, 2019

I guess they will live here yes. But I didn't get what you mean with put it in the readme?

@kelset
Copy link
Member

kelset commented Jun 12, 2019

oh sorry 😅 yeah I meant, like a section of the readme explaining how comments inline can be added

@kelset
Copy link
Member

kelset commented Jun 12, 2019

my only concern is, what will happen if we have let's say a jump from 57 to 59, and the comment that we want to show was something that would be in 58?

@lucasbento
Copy link
Member Author

@kelset: it will show anyway unless 0.59 has a comment on the same line.

Add useful content section 📣 & binary download ⬇️ button
@lucasbento lucasbento merged commit 2c4a45f into master Jun 12, 2019
@lucasbento lucasbento deleted the feat/comments-in-diff branch June 12, 2019 18:35
@lucasbento
Copy link
Member Author

@kelset: about adding docs for comments I created #28 to keep track of it.

@kelset kelset mentioned this pull request Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants