-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show comments in the diff #18
Conversation
🤣 I looooove those comments! I don't even need to talk about the second one! |
So the only blocker here for now is the copy for the comments? |
bcee9e0
to
feb07af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
Gotcha - I guess we want to have that in the readme right? Because these comments will live in this repo |
I guess they will live here yes. But I didn't get what you mean with put it in the readme? |
oh sorry 😅 yeah I meant, like a section of the readme explaining how comments inline can be added |
my only concern is, what will happen if we have let's say a jump from 57 to 59, and the comment that we want to show was something that would be in 58? |
@kelset: it will show anyway unless |
feb07af
to
7cbf274
Compare
Add useful content section 📣 & binary download ⬇️ button
Summary
This PR adds the ability to show comments in the diff, the comments are provided by a file under
./src/releases
. Related to #10.Test Plan
Run the app locally and select
0.60.0.rc-0
as the destination version.