Fix issue with AppName stripping incorrectly. #379
+35
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
blakef
force-pushed
the
fix-appname-stripping
branch
from
cca3815 to
4e71a7f
Compare
When appName or appPackage are empty, set the state to the default values. This makes the down-tree props simpler to understand. Also more strictly strip the prefix AppName from the filepath to avoid edgecases.
blakef
force-pushed
the
fix-appname-stripping
branch
from
4e71a7f to
7ef8fb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles cases where appName wasn't playing nicely with it's default value.
Summary
The
appNameis meant to be stripped off in various places. When setting the default, the actual value passed around is''. This change does 2 things:appNamedown the tree when an empty string is inputted.Before
After
CleanShot.2024-02-26.at.22.35.52.mp4
Test Plan
yarn startWhat are the steps to reproduce?
You can see it live.
Checklist
README.md(if needed)