-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android library builds broken after upgrade to 0.63 #93
Comments
github-actions
bot
added
0.63.1
🙁 No upgrading version specified
and removed
0.63.1
labels
Aug 4, 2020
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this issue
Aug 23, 2021
…32026) Summary: Fixes #29577 and react-native-community/upgrade-support#93, when building an android library the package task has a different name, which was not handled correctly in the react.gradle file. The fix uses the existing `packageTask` variable which is correctly set for applications and libraries. This PR also copies the bundled js file into the correct assets directory, which is different from the assets directory of applications. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [Android] [Fixed] - Fixed Android library builds with react.gradle file Pull Request resolved: #32026 Test Plan: Tested with my android library build which includes the `react.gradle` file and the build succeeded. Reviewed By: sshic, ShikaSD Differential Revision: D30368771 Pulled By: cortinico fbshipit-source-id: 8f0df8c4d0fa38d85f7c0b9af56d88799571191d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Environment
System:
OS: macOS 10.15.5
CPU: (12) x64 Intel(R) Core(TM) i9-8950HK CPU @ 2.90GHz
Memory: 1.17 GB / 16.00 GB
Shell: 5.7.1 - /bin/zsh
Binaries:
Node: 10.13.0 - ~/.nvm/versions/node/v10.13.0/bin/node
Yarn: 1.22.4 - ~/.yarn/bin/yarn
npm: 6.7.0 - ~/.nvm/versions/node/v10.13.0/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 13.2, DriverKit 19.0, macOS 10.15, tvOS 13.2, watchOS 6.1
Android SDK:
API Levels: 23, 28, 29
Build Tools: 28.0.3, 29.0.2, 29.0.3
System Images: android-29 | Google Play Intel x86 Atom
IDEs:
Android Studio: 4.0 AI-193.6911.18.40.6626763
Xcode: 11.3.1/11C504 - /usr/bin/xcodebuild
npmPackages:
react: 16.13.1 => 16.13.1
react-native: 0.63.1 => 0.63.1
Upgrading version
0.59.10 ->0.63.1
Description
Our application is a hybrid and it consume our react native in android as a library. After following the upgrade guide and upgrading all our packages to the latest, I'm running into an issue where some gradle task called
packageDebug
is nullrunning
./gradle clean build --stacktrace
from the android repo results in the output belowif I edit the react native gradle file on line 346 to disable vm cleanup:
and run the build again, react native cannot find the correct paths to any jars to jetify:
./android/build.gradle
./android/app/build.gradle
./android/lib-reactnative/build.gradle
The text was updated successfully, but these errors were encountered: