Tidying tests, readying for release

react-native-contrib · May 16, 2016 · 7323084 · 7323084
1 parent dbd1982
commit 7323084
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 20 deletions.
diff --git a/src/validate.js b/src/validate.js
@@ -33,7 +33,7 @@ const isPlugin = (dependency) => {
  */
 const isProject = () => {
     const pkg = require('./project').getPackageJson(process.env.RN_PROJECT_ROOT);
-    var result = false;
+    let result = false;
 
     if (Object.keys(pkg).length === 0) {
         return result;

diff --git a/tests/path.spec.js b/tests/path.spec.js
@@ -14,7 +14,7 @@ describe('path', () => {
     describe('#isFile', () => {
 
         it('should return true for an existing file', () => {
-            expect(pathUtils.isFile(path.join(__dirname, 'fixtures', 'file.txt'))).to.deep.equals(true);
+            expect(pathUtils.isFile(path.join(__dirname, 'fixtures', 'file.txt'))).to.be.true;
         });
 
         it('should throw an error for a nonexistent file', () => {
@@ -28,7 +28,7 @@ describe('path', () => {
     describe('#isDirectory', () => {
 
         it('should return true for an existing directory', () => {
-            expect(pathUtils.isDirectory(path.join(__dirname, 'fixtures'))).to.deep.equals(true);
+            expect(pathUtils.isDirectory(path.join(__dirname, 'fixtures'))).to.be.true;
         });
 
         it('should throw an error for a nonexistent directory', () => {
@@ -50,7 +50,7 @@ describe('path', () => {
             });
 
             pathUtilsMock.makeDirectory(process.cwd());
-            expect(stub.calledTwice).to.deep.equals(true);
+            expect(stub.calledTwice).to.be.true;
         });
 
         it('should not create a directory if one exists', () => {
@@ -62,7 +62,7 @@ describe('path', () => {
             });
 
             pathUtilsMock.makeDirectory(process.cwd());
-            expect(stub.calledOnce).to.deep.equals(true);
+            expect(stub.calledOnce).to.be.true;
         });
 
     });

diff --git a/tests/process.spec.js b/tests/process.spec.js
@@ -1,11 +1,11 @@
 'use strict';
 
-const chai = require('chai');
-const sinon = require('sinon');
-const rewire = require('rewire');
-const path = require('path');
+let chai = require('chai');
+let sinon = require('sinon');
+let rewire = require('rewire');
+let path = require('path');
 
-const expect = chai.expect;
+let expect = chai.expect;
 let spawnError = false;
 let processUtilsMock = rewire('../src/process');
 processUtilsMock.__set__('spawn', () => {
@@ -17,32 +17,32 @@ processUtilsMock.__set__('spawn', () => {
 describe('process', () => {
 
     describe('#run', () => {
-        const command = processUtilsMock.run('echo');
+        let command = processUtilsMock.run('echo');
 
         it('should generate a function around shell command', () => {
-            expect(typeof command).to.deep.equals('function');
+            expect(command).to.be.a('function');
         });
 
         it('should throw an error if no callback was provided', () => {
             expect(() => command()).to.throw('You missed a callback function');
         });
 
         it('should invoke a callback after command execution', () => {
-            const spy = sinon.spy();
+            let spy = sinon.spy();
             command(spy);
-            expect(spy.callCount).to.equals(1);
+            expect(spy.calledOnce).to.be.true;
         });
 
-        it('should throw an error if process exited with a code');
+        // it('should throw an error if process exited with a code');
         // it('should throw an error if process exited with a code', () => {
-        //     const errorCommand = processUtils.run('sleep 10');
-        //     const spy = sinon.spy();
+        //     let errorCommand = processUtilsMock.run('sleep 10');
+        //     let spy = sinon.spy();
         //     expect(() => errorCommand(spy)).to.throw('Error occurred while executing');
         // });
 
         it('should throw an error if spawn ended up with error', () => {
             spawnError = true;
-            const spy = sinon.spy();
+            let spy = sinon.spy();
             expect(() => command(spy)).to.throw();
         });
     });

diff --git a/tests/project.spec.js b/tests/project.spec.js
@@ -16,12 +16,12 @@ describe('project', () => {
 
         it('should return the package file as a JSON object', () => {
             let projectPath = path.join(__dirname, 'fixtures', 'react-native-project');
-            expect(projectUtils.getPackageJson(projectPath).name).to.deep.equals('VideoApp');
+            expect(projectUtils.getPackageJson(projectPath).name).to.eql('VideoApp');
         });
 
         it('should return an empty array if no package file exists', () => {
             let nonprojectPath = path.join(__dirname, 'fixtures');
-            expect(projectUtils.getPackageJson(nonprojectPath)).to.deep.equals({});
+            expect(projectUtils.getPackageJson(nonprojectPath)).to.be.empty;
         });
 
     });