Dismiss android pickers on react component unmount #326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
whops i made these too early, going to fix some fmt, doc etc first before marking as not draft. |
aleksanb
force-pushed
the
dismiss-datepicker
branch
from
41354dd to
3b6b2d0
Compare
aleksanb
changed the title
aleksanb
force-pushed
the
dismiss-datepicker
branch
from
3b6b2d0 to
dcc8f95
Compare
This commit makes the behavior of the android datetimepickers more in line with other controlled components in react, where unmounting the component actually dismisses the ui widget as well. Co-authored-by: Stian Jensen <me@stianj.com>
aleksanb
force-pushed
the
dismiss-datepicker
branch
from
dcc8f95 to
695c92b
Compare
5 tasks
5 tasks
|
closed in favor of #337 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit makes the behavior of the android datetimepickers more in
line with other controlled components in react, where unmounting the
component actually dismisses the ui widget as well.
Test Plan
What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.mdexample/App.js)