feat: update podspec #776
Merged
feat: update podspec #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vonovak
pushed a commit
that referenced
this pull request
Jun 27, 2023
# [7.3.0](v7.2.0...v7.3.0) (2023-06-27) ### Features * update podspec ([#776](#776)) ([bd9f363](bd9f363))
|
🎉 This issue has been resolved in version 7.3.0 🎉 If this package helps you, consider sponsoring us! 🚀 |
billnbell
reviewed
Jul 12, 2023
| s.dependency "RCTTypeSafety" | ||
| s.dependency "ReactCommon/turbomodule/core" | ||
|
|
||
| if ENV['RCT_NEW_ARCH_ENABLED'] == '1' |
There was a problem hiding this comment.
Not sure you want to wrap this with RCT_NEW_ARCH_ENABLED. I would not since the code already does that. They may add for various combos of RCT_NEW_ARCH_ENABLED.
There was a problem hiding this comment.
There was a problem hiding this comment.
good catch! I'll update it at some point / feel free to open a PR, thank you! :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
just making the podspec shorter
Test Plan
What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.mdexample/App.js)