Fix: new arch support for 0.74 #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentvatne
merged commit 950cea9
into
react-native-datetimepicker:master
4 of 5 checks passed
5 tasks
|
🎉 This issue has been resolved in version 8.0.0 🎉 If this package helps you, consider sponsoring us! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The signature for
ComponentDescriptor::adoptwas changed here. Currently the library will only build on RN 0.72. These changes will not support 0.72 because a pick was missed. I spoke to Riccardo and this will be backported soonTest Plan
Tested in our (Expos) sample app. The app builds successfully and the library works as expected.
What's required for testing (prerequisites)?
A RN 0.74 project, new arch, bridgeless.
What are the steps to reproduce (after prerequisites)?
Checklist
README.mdexample/App.js)