Added pickDirectory() implementation for Windows (proper PR) #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmatteoq
changed the title
2 tasks
vonovak
approved these changes
Aug 2, 2021
3 tasks
|
thank you @qmatteoq! :) |
vonovak
added a commit
that referenced
this pull request
Aug 9, 2021
* feat: rework module using react native bob * chore: rebase * Added windows example (not working for the moment) * Fixed implementation of the Windows example * Fixed Lint issues * Fixed a missing Lint issue * Fixed another missing Lint issue * fix: fixed all the pending Lint issues * Added pickDirectory() implementation for Windows (proper PR) (#444) * feat: added pickDirectory implementation for Windows * fix: fixed typo in property name Co-authored-by: Matteo Pagani <matteo.pagani@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds Windows support for the pickDirectory() function.
Test Plan
What's required for testing (prerequisites)?
See the official prerequisites for React Native for Windows here
What are the steps to reproduce (after prerequisites)?
Move to the root of the project and run:
yarn example windowsCompatibility
Checklist
README.md