Support React Native 0.78 for react-native-document-picker #827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e41b9ae The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
1 task
vonovak
requested changes
May 14, 2025
There was a problem hiding this comment.
Hello and thank you for the PR!
The way I see it, there are a bit too many changes here.
AFAICT, it should be enough to change GuardedResultAsyncTask to AsyncTask.
I know that class is deprecated but for the sake of unblocking 78, I'd prefer to do minimal changes.
For those who don't want to use deprecated stuff, please move over to @react-native-documents/picker.
Thank you! :)
|
I understand your point about making minimal changes, especially for a deprecated package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the package.
GuardedResultAsyncTask is being used in RNDocumentPickerModule.java which is no longer supported in react-native 0.78.0. This is the fix for
react-native-document-pickerpackage.And is it possible to make a new release for
react-native-document-pickerafter the fix, currently I cannot migrate to@react-native-documents/picker.