Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why: the current API is a bit clumsy when it comes to handling errors and reacting to them
ex: to handle the sign in cancellation, you're required to implement this in the catch block. It's not unlikely that the code handling cancellation will be empty:
The changes in this PR mean that only "real errors" are propagated to the
catch
block. Cancellation is handled in thetry
block:Same change is present for
addScopes
andsignInSilently
-statusCodes.SIGN_IN_REQUIRED
was removed and is now handled as follows:This makes the api a little nicer to work with and the non-success cases are more explicitly visible in the API.
additionally, this PR fixes #1070