Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'useNativeDriver: false' to Animated.timing to suppress warnings in React Native v0.62 #3484

Merged
merged 1 commit into from
Jul 20, 2020

Conversation

liamlows
Copy link
Contributor

Does any other open PR do the same thing?

No

What issue is this PR fixing?

When using React Native v0.62, a consistent warning will generate when using an animated region and animated marker. The warning (seen below) can be suppressed on iOS by setting the option useNativeDriver: false in AnimatedRegion.js.

Issue

Warning: Animated: 'useNativeDriver' was not specified. This is a required option and must be explicitly set to 'true' or 'false'

How did you test this PR?

I created an animated marker and then used an animated region when generating the coordinate. I then ran the build on my iPhone 11 Pro Max using xcode on iOS 13.5. The warnings that used to pop up no longer popped up.

@rborn
Copy link
Collaborator

rborn commented Jul 20, 2020

😻

@rborn rborn merged commit 246ae0c into react-native-maps:master Jul 20, 2020
@byteab
Copy link

byteab commented Sep 21, 2020

What's the point of setting it to false. only to suppress the warning. Marker.Animated cause a lot of lag in IOS.

pinpong pushed a commit to pinpong/react-native-maps that referenced this pull request Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants