Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS menu is displayInlined with 0.74 and new architecture when not set #784

Closed
alanleedev opened this issue Apr 29, 2024 · 1 comment
Closed

Comments

@alanleedev
Copy link
Contributor

NOTE: This issue requires fix in React Native codegen but filing here for folks who may run into the issue in the meanwhile.
This issue is expected to be fixed in react-native PR: facebook/react-native#44294

Problem:
So Props.h file generated from native component codegen does not properly initialize C++ struct.
So in effect, if you run the example code on iOS, displayInline which is an optional prop in MenuView unintentionally can be set to true as it is not initialized properly in C++ and sub menus can appear at top level.
Also using WithDefault in the TypeScript spec file does not fix this.

@alanleedev
Copy link
Contributor Author

This issue is fixed with 74.0.1 (PR for fix)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant