Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.74] add missing default initializer for struct in Props.h generated via codegen #271

Closed
cipolleschi opened this issue May 1, 2024 · 1 comment
Closed

[0.74] add missing default initializer for struct in Props.h generated via codegen #271

cipolleschi opened this issue May 1, 2024 · 1 comment
Assignees
@cipolleschi
Labels
Type: Pick Request

Comments

@cipolleschi
Copy link
Collaborator

Target Branch(es)

0.74

Link to commit or PR to be picked

facebook/react-native@639d890

Description

Found that generated struct in Props.h file is missing default initializers and can lead to unexpected behavior.
This issue (PR here) was discovered while testing menu library and this fix is needed to support it properly with new architecture.
@cipolleschi
Copy link
Collaborator Author

picked ✅

@github-project-automation github-project-automation bot moved this from Inbox to Done / Picked in React Native 0.74 Releases May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cipolleschi cipolleschi

Labels
Type: Pick Request
Projects
React Native 0.74 Releases
Status: Done / Picked
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cipolleschi