README Suggestions : Avoid Flashes Case on iOS #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tell the user not to set `backgroundColor` style to the `Modal` as it will cause flickering on iOS.
louisiscoding
changed the title
|
Thank you 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the 'flashes' episode we had on
react-native-modal(#92).I found myself subject to some flashes when using the component on iOS.
And i've found out it was caused because i was setting a backgroundColor
whitedirectly to my Modal component instead of the child 'container'.In order to avoid that someone else reproduce this mistake and goes through the same process, i'd like to suggest that we add a text to the READMe.md file to tell the user not to set
backgroundColorstyle to theModalas it will cause flashes on iOS.