Skip to content

fix: remove completionHandler from finish #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 25, 2020
Merged

fix: remove completionHandler from finish #241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58c0368
fix: remove completionHandler from finish
Naturalclar Nov 25, 2020
fe6f8e5
chore: remove node 10 from ci
Naturalclar Nov 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ jobs:
runs-on: ubuntu-18.04
strategy:
matrix:
node-version: [10,12,14]
node-version: [12,14]
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
Expand All @@ -27,7 +27,7 @@ jobs:
runs-on: ubuntu-18.04
strategy:
matrix:
node-version: [10,12,14]
node-version: [12,14]
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
Expand All @@ -48,7 +48,7 @@ jobs:
runs-on: ubuntu-18.04
strategy:
matrix:
node-version: [10,12,14]
node-version: [12,14]
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
Expand All @@ -69,7 +69,7 @@ jobs:
runs-on: macos-latest
strategy:
matrix:
node-version: [10,12,14]
node-version: [12,14]
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
Expand Down
1 change: 1 addition & 0 deletions example/ios/example/AppDelegate.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ - (void)userNotificationCenter:(UNUserNotificationCenter *)center
didReceiveNotificationResponse:(UNNotificationResponse *)response
withCompletionHandler:(void (^)(void))completionHandler {
[RNCPushNotificationIOS didReceiveNotificationResponse:response];
completionHandler();
}

- (NSURL *)sourceURLForBridge:(RCTBridge *)bridge {
Expand Down
9 changes: 2 additions & 7 deletions ios/RNCPushNotificationIOS.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,13 +168,8 @@ - (void)handleRemoteNotificationRegistrationError:(NSNotification *)notification
[self sendEventWithName:@"remoteNotificationRegistrationError" body:errorDetails];
}

RCT_EXPORT_METHOD(onFinishRemoteNotification:(NSString *)notificationId fetchResult:(UIBackgroundFetchResult)result) {
RNCRemoteNotificationCallback completionHandler = self.remoteNotificationCallbacks[notificationId];
if (!completionHandler) {
RCTLogError(@"There is no completion handler with notification id: %@", notificationId);
return;
}
completionHandler(result);
RCT_EXPORT_METHOD(onFinishRemoteNotification:(NSString *)notificationId fetchResult:(UIBackgroundFetchResult)result)
{
[self.remoteNotificationCallbacks removeObjectForKey:notificationId];
}

Expand Down