Separate react native part from rest of Android code #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(crap, forgot to add edit: fixed |
LinusU
force-pushed
the
separate-react-native
branch
from
b282ab3 to
4ee21f7
Compare
|
Successfully tested on our app, thanks @LinusU ! |
|
@LinusU after more investigation, it appear that this PR breaks the way that callkeep wakes up the application when we try to make a call from the native application. Do you have an idea how to deal with this issue in react-native and Flutter ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to use the CallKeep part from Flutter, with these changes I think that we should be able to do that☺️