New Method Check if Active Call with UUID #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuquentin
requested changes
Mar 23, 2020
|
I’ll be pushing these changes later tonight, thank you for the feedback this is my first PR and attempt to add something to an open source package |
|
I have made the requested changes and updated the documentation to reflect the added function. |
|
@manuquentin is it correct now? |
|
I've to check it |
…ommits this is my first time doing this
…ommits this is my first time doing this
|
@manuquentin are you happy to merge this? Looks good to me I think. Ideally it would document the fact the method is available to native too in the readme but thats a small detail |
manuquentin
approved these changes
May 15, 2020
|
Thanks, released in |
|
I do have updates to this I can push as well, and iirc I did document there is a native and js version. Not sure if that matters. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IOS Only similar to checkIfBusy, allows the user to check if the specified call UUID is the active call.
This is available on both the React Native and IOS Native side.
I added this due to a need to cancel the incoming call UI via Push notification. This should be feasible on Android however IOS requires notifications to be handled in the background in order for the incoming call UI to be canceled.