Add completionHandler for reportNewIncomingCall method #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…comingCall. Which is usefull if you want to tell the pushkit you handled the VoIP notification only after the call was successfully reported.
…er, so it is not a breaking change.
manuquentin
approved these changes
May 12, 2020
|
Thanks @lrorthmann ! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the possibility to add a completionHandler for the reportNewIncomingCall. Which is usefull if you want to tell the Pushkit you handled the VoIP notification only after the call was successfully reported to CXProvider.
The reasoning is that some times the incoming call screen from CallKit doesn't show if the App isn't in foreground if the completion handler from PushKit is called immediately (not waiting for the CXProvider to finish the call report) and then only after the user opens the App is when the screen pops up.