Audio route to speaker for Android platform #295

vtn-dev-prithipal · 2020-09-24T12:19:41Z

Added a function that routes audio to the speaker for the Android platform

Issue: When Callkeep Active Call UI and custom Call UI are active simultaneously and the user tries to route the audio to the speaker from the earpiece or vice-versa from the custom call screen. The android connection service doesn't release the audio manager and the application is unable to change the state via the audio manager.

jpotts18 · 2020-10-08T15:54:09Z

What else can we do to get this merged in @manuquentin? Seems purely additive.

manuquentin · 2020-10-08T15:57:11Z

index.js

@@ -149,6 +149,8 @@ class RNCallKeep {

  sendDTMF = (uuid, key) => RNCallKeepModule.sendDTMF(uuid, key);

+  toggleAudioRouteSpeaker = (uuid, useSpeaker) => RNCallKeepModule.toggleAudioRouteSpeaker(uuid, useSpeaker);


Can you check to only call it on Android please ?

yup, let me make this Android-specific function

android/src/main/java/io/wazo/callkeep/RNCallKeepModule.java

manuquentin · 2020-10-08T15:58:14Z

Thanks @vtn-dev-prithipal

I've made some comments in your code. Can you please check them ?

danjenkins · 2020-10-08T15:59:35Z

@jpotts18 I havent looked at it properly yet.... but the first thing I can see is theres no if iOS check on the JS api - right now, it would error out in ios.

I'm not even 100% sure this should be in here. For example... I use the react-native-call-manager package and I'm able to control the UI routing using that....

I don't see why this module should get involved with it.... what if I use an external module to control the audio session etc? I'm not saying no to the PR, I just need to understand it better

manuquentin · 2020-10-08T16:05:26Z

Hi Dan,
Regarding this feature in this library, we asked the same question with @sboily as we also use react-native-incall-manager.

But here, it seem to work directly on the VoiceConnection, I don't think that react-native-incall-manager could interact directly with the VoiceConnection. And maybe yes, this could belong here.

danjenkins · 2020-10-08T16:08:43Z

Yeah... @manuquentin I'm unsure why interacting on the voice connection directly is needed.... I don't want to say this shouldn't get merged.... but I'd argue to the docs need to be super clear why you'd use it here vs using say in-call-manager

vtn-dev-prithipal · 2020-10-08T17:56:23Z

Hi Dan,
Regarding this feature in this library, we asked the same question with @sboily as we also use react-native-incall-manager.

But here, it seems to work directly on the VoiceConnection, I don't think that react-native-incall-manager could interact directly with the VoiceConnection. And maybe yes, this could belong here.

-- react-native-incall-manager is using AudioManager class for a toggle speaker. In our case, we are also using the AudioManager but its unable to route the audio to the speaker when we try to control the call actions from our app UI instead of native call UI.

Scenario: Whenever the user answer the calls and the app receives an answer event
RNCallKeep.addEventListener('answerCall', ({ callUUID }) => , we show our app with custom active call UI/UX
using RNCallKeep.backToForeground() function. When the user tries to toggle the speaker button on our app screen, App tries to invoke AudioManager to set the speaker's phone on but it fails every time. I found out that the voice connection class has control of the audio manager and release after the end of the calls.

geraintwhite · 2020-12-22T09:39:10Z

@vtn-dev-prithipal does a similar thing need to be done for muting?

In my app I use AudioManager.setSpeakerphoneOn(enabled); and AudioManager.setMicrophoneMute(enabled); from my custom call UI and muting works fine but speaker doesn't (as you explained).

Edit:

Nevermind - I just noticed that there already is setMutedCall!

geraintwhite · 2020-12-22T11:50:12Z

I've tested this PR and it works well when using RNCallKeep.backToForeground().

android/src/main/java/io/wazo/callkeep/RNCallKeepModule.java

+    @ReactMethod
+    public void toggleAudioRouteSpeaker(String uuid, boolean useSpeaker) {
+        VoiceConnection conn = (VoiceConnection) VoiceConnectionService.getConnection(uuid);
+        if (conn == null) {
+            return;
+        }
+     if(useSpeaker){
+         conn.setAudioRoute(CallAudioState.ROUTE_SPEAKER);
+     }else{
+         conn.setAudioRoute(CallAudioState.ROUTE_EARPIECE);
+     }
+    }
+


index.d.ts

+    /**
+         * @description toggleAudioRouteSpeaker method is available only on Android.
+      */
+    static toggleAudioRouteSpeaker(uuid: string, useSpeaker: boolean) {

+    }


index.js

@@ -149,6 +149,8 @@ class RNCallKeep {

  sendDTMF = (uuid, key) => RNCallKeepModule.sendDTMF(uuid, key);

+  toggleAudioRouteSpeaker = (uuid, useSpeaker) => RNCallKeepModule.toggleAudioRouteSpeaker(uuid, useSpeaker);


…-native-callkeep into speakerOutputAndroid

1. Indentation issue 2. platform specific-check

vtn-dev-prithipal

as per suggestion, changes are updated

geraintwhite · 2021-01-28T10:46:28Z

@manuquentin is this any closer to being merged? I've been using it for a while in my app via patch-package and it works perfectly with RNCallKeep.backToForeground().

sboily

Hello, please add documentation and we'll merge it.

geraintwhite · 2021-03-19T09:52:45Z

I'm happy to add some documentation if @vtn-dev-prithipal is unable to?

…-native-callkeep into speakerOutputAndroid

vtn-dev-prithipal · 2021-03-19T10:47:46Z

I'm happy to add some documentation if @vtn-dev-prithipal is unable to?

yes, please. I have added few lines. @grit96 please review and make changes if necessary.

index.d.ts

vtn-dev-prithipal · 2021-03-19T11:20:06Z

index.js

+  /**
+   * @description when Phone call is active, Android control the audio service via connection service. so this function help to toggle the audio to Speaker or wired/ear-piece or vice-versa 
+   * @param {*} uuid 
+   * @param {*} routeSpeaker
+   * @returns Audio route state of audio service
+   */


updated here b0a2fda

please review

Co-authored-by: Geraint White <geraintwhite@gmail.com>

…thipal/react-native-callkeep into speakerOutputAndroid

README.md

sboily · 2021-03-19T11:37:58Z

Thank you!

sboily · 2021-03-19T11:39:31Z

@manuquentin please review and merge it if everything is correct.

Co-authored-by: Geraint White <geraintwhite@gmail.com>

manuquentin · 2021-03-19T19:45:31Z

android/src/main/java/io/wazo/callkeep/RNCallKeepModule.java

+        if (conn == null) {
+            return;
+        }
+        if(useSpeaker){


It should be routeSpeaker here.
Can you please also reformat code and add space before ( and after ).
Same for the else below, space before { and after }.

1. param routeSpeaker updated . 2. reformated code

…thipal/react-native-callkeep into speakerOutputAndroid

developer-vtnetzwelt · 2021-03-22T13:45:01Z

Thanks @vtn-dev-prithipal

I've made some comments in your code. Can you please check them ?

Thanks @ vtn-dev-prithipal

Audio route to speaker for Android platform

be5f3fb

manuquentin requested changes Oct 8, 2020

View reviewed changes

geraintwhite suggested changes Dec 23, 2020

View reviewed changes

vtn-dev-prithipal added 2 commits January 5, 2021 23:11

Merge branch 'master' of https://github.com/react-native-webrtc/react…

adc6bba

…-native-callkeep into speakerOutputAndroid

review suggestion changes updated

49d984f

1. Indentation issue 2. platform specific-check

vtn-dev-prithipal commented Jan 5, 2021

View reviewed changes

vtn-dev-prithipal requested a review from manuquentin January 5, 2021 17:57

geraintwhite approved these changes Jan 5, 2021

View reviewed changes

geraintwhite approved these changes Jan 28, 2021

View reviewed changes

sboily requested changes Feb 19, 2021

View reviewed changes

sboily added the waiting for feedback Waiting for feedback label Feb 19, 2021

vtn-dev-prithipal added 3 commits March 19, 2021 15:56

added function documenttation

3fc6c55

Merge branch 'master' of https://github.com/react-native-webrtc/react…

c34ae22

…-native-callkeep into speakerOutputAndroid

Update the param naming convension

749318c

vtn-dev-prithipal requested a review from sboily March 19, 2021 10:48

geraintwhite suggested changes Mar 19, 2021

View reviewed changes

vtn-dev-prithipal and others added 3 commits March 19, 2021 16:36

Update index.d.ts

6c4a7cb

Co-authored-by: Geraint White <geraintwhite@gmail.com>

Added documentation for toggleAudioRouteSpeaker function

b0a2fda

Merge branch 'speakerOutputAndroid' of https://github.com/vtn-dev-pri…

7c69d82

…thipal/react-native-callkeep into speakerOutputAndroid

geraintwhite suggested changes Mar 19, 2021

View reviewed changes

README.md Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

geraintwhite approved these changes Mar 19, 2021

View reviewed changes

sboily approved these changes Mar 19, 2021

View reviewed changes

vtn-dev-prithipal and others added 2 commits March 19, 2021 19:22

Update README.md

4dd66ad

Co-authored-by: Geraint White <geraintwhite@gmail.com>

Update README.md

b431d5c

Co-authored-by: Geraint White <geraintwhite@gmail.com>

manuquentin requested changes Mar 19, 2021

View reviewed changes

vtn-dev-prithipal added 2 commits March 22, 2021 11:50

manuquentin requested changes updated

e68ec34

1. param routeSpeaker updated . 2. reformated code

Merge branch 'speakerOutputAndroid' of https://github.com/vtn-dev-pri…

af87fcf

…thipal/react-native-callkeep into speakerOutputAndroid

vtn-dev-prithipal requested a review from manuquentin March 22, 2021 06:23

manuquentin approved these changes Mar 22, 2021

View reviewed changes

manuquentin merged commit 9e7b1f5 into react-native-webrtc:master Mar 22, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Audio route to speaker for Android platform #295

Audio route to speaker for Android platform #295

vtn-dev-prithipal commented Sep 24, 2020 •

edited

Loading

jpotts18 commented Oct 8, 2020 •

edited

Loading

manuquentin Oct 8, 2020

vtn-dev-prithipal Oct 8, 2020

manuquentin commented Oct 8, 2020

danjenkins commented Oct 8, 2020

manuquentin commented Oct 8, 2020 •

edited

Loading

danjenkins commented Oct 8, 2020

vtn-dev-prithipal commented Oct 8, 2020

geraintwhite commented Dec 22, 2020 •

edited

Loading

geraintwhite commented Dec 22, 2020

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

vtn-dev-prithipal left a comment

geraintwhite commented Jan 28, 2021

sboily left a comment

geraintwhite commented Mar 19, 2021

vtn-dev-prithipal commented Mar 19, 2021

This comment was marked as resolved.

vtn-dev-prithipal Mar 19, 2021

sboily commented Mar 19, 2021

sboily commented Mar 19, 2021

manuquentin Mar 19, 2021

developer-vtnetzwelt commented Mar 22, 2021

		@@ -149,6 +149,8 @@ class RNCallKeep {

		sendDTMF = (uuid, key) => RNCallKeepModule.sendDTMF(uuid, key);

		toggleAudioRouteSpeaker = (uuid, useSpeaker) => RNCallKeepModule.toggleAudioRouteSpeaker(uuid, useSpeaker);

Audio route to speaker for Android platform #295

Audio route to speaker for Android platform #295

Conversation

vtn-dev-prithipal commented Sep 24, 2020 • edited Loading

jpotts18 commented Oct 8, 2020 • edited Loading

manuquentin Oct 8, 2020

Choose a reason for hiding this comment

vtn-dev-prithipal Oct 8, 2020

Choose a reason for hiding this comment

manuquentin commented Oct 8, 2020

danjenkins commented Oct 8, 2020

manuquentin commented Oct 8, 2020 • edited Loading

danjenkins commented Oct 8, 2020

vtn-dev-prithipal commented Oct 8, 2020

geraintwhite commented Dec 22, 2020 • edited Loading

geraintwhite commented Dec 22, 2020

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

vtn-dev-prithipal left a comment

Choose a reason for hiding this comment

geraintwhite commented Jan 28, 2021

sboily left a comment

Choose a reason for hiding this comment

geraintwhite commented Mar 19, 2021

vtn-dev-prithipal commented Mar 19, 2021

This comment was marked as resolved.

vtn-dev-prithipal Mar 19, 2021

Choose a reason for hiding this comment

sboily commented Mar 19, 2021

sboily commented Mar 19, 2021

manuquentin Mar 19, 2021

Choose a reason for hiding this comment

developer-vtnetzwelt commented Mar 22, 2021

vtn-dev-prithipal commented Sep 24, 2020 •

edited

Loading

jpotts18 commented Oct 8, 2020 •

edited

Loading

manuquentin commented Oct 8, 2020 •

edited

Loading

geraintwhite commented Dec 22, 2020 •

edited

Loading