Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing types #373

Merged
merged 1 commit into from
Feb 26, 2021
Merged

Fixing types #373

merged 1 commit into from
Feb 26, 2021

Conversation

maludwig
Copy link
Contributor

The CONSTANTS were not in the typescript definition. This simply adds them.

To recreate the issue, in any typescript file:

import {CONSTANTS} from 'react-native-callkeep';
console.log(CONSTANTS);

eslint or tsc will complain about the types not being there

@maludwig maludwig mentioned this pull request Feb 26, 2021
Closed
2 tasks
@sboily sboily merged commit 51c4b07 into react-native-webrtc:master Feb 26, 2021
@maludwig maludwig deleted the fixing-constant-types branch March 3, 2021 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sboily sboily sboily approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maludwig @sboily