-
Notifications
You must be signed in to change notification settings - Fork 1.3k
video effect registry done #1176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
video effect registry done #1176
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking much better! Please take a look and my comments and make sure to add documentation to every new class and method describing what it does and what the parameters are and do.
android/src/main/java/com/oney/WebRTCModule/GetUserMediaImpl.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/oney/WebRTCModule/GetUserMediaImpl.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/oney/WebRTCModule/GetUserMediaImpl.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/oney/WebRTCModule/GetUserMediaImpl.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/oney/WebRTCModule/videoEffect/ProcessorProvider.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/oney/WebRTCModule/videoEffect/ProcessorProvider.java
Show resolved
Hide resolved
android/src/main/java/com/oney/WebRTCModule/videoEffect/ProcessorProvider.java
Show resolved
Hide resolved
android/src/main/java/com/oney/WebRTCModule/videoEffect/VideoEffectProcessor.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/oney/WebRTCModule/videoEffect/VideoFrameProcessor.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/oney/WebRTCModule/GetUserMediaImpl.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/oney/WebRTCModule/videoEffects/ProcessorProvider.java
Show resolved
Hide resolved
android/src/main/java/com/oney/WebRTCModule/videoEffects/ProcessorProvider.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/oney/WebRTCModule/videoEffects/ProcessorProvider.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/oney/WebRTCModule/videoEffects/VideoEffectProcessor.java
Show resolved
Hide resolved
android/src/main/java/com/oney/WebRTCModule/videoEffects/VideoFrameProcessor.java
Show resolved
Hide resolved
Can you please paste a link to the blur example? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM can you have one final look @tmoldovan8x8 ?
@SHIVAJIKUMAR007 don't we need to release the frame if |
yes, you are right. |
This work was done during Google Summer of Code 2022 under the Jitsi organization. Mentors: @saghul and @tmoldovan8x8.
0198ba4
to
74b1e77
Compare
Congrats @SHIVAJIKUMAR007 this is now merged and will be part of the next release! |
Thanks, @saghul and @tmoldovan8x8 for all the guidance and support. |
really good, thannk so much, @SHIVAJIKUMAR007 , could you please share some processor to blur the person background for example? |
you can check my repo : https://github.com/SHIVAJIKUMAR007/real-time-VideoProcessing/tree/master/android/app/src/main/java/com/vchat/backgroundEffect |
@SHIVAJIKUMAR007 , can i ask about where localtion i need to implement VideoFrameProcessorFactoryInterface , or can just implement to android native code in project along @reeactMethod? because my plan are add background with custom image by filter with Ai segmention(i use tensorflow lite AI) , can your tell me logic to handle my case? thank! |
this is the video effect registry
to create a video effect you have to implement VideoFrameProcessorFactoryInterface
for example :
then you have to add this processor in processor map
your videoEffect is registered now
to apply this videoEffect you have to call mediaStreamTrack._setVideoEffect(name);
and to remove this effect you just call mediaStreamTrack._setVideoEffect(null);