Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prism theme is incorrect #9

Closed
Simek opened this issue Sep 10, 2020 · 5 comments · Fixed by #16
Closed

Prism theme is incorrect #9

Simek opened this issue Sep 10, 2020 · 5 comments · Fixed by #16

Comments

@Simek
Copy link

Simek commented Sep 10, 2020

vs

@darshkpatel
Copy link
Member

Should we have different themes for darkMode / Light since docusaurus v2 supports different prism themes depending on the mode

@Simek
Copy link
Author

Simek commented Sep 11, 2020

I think that at the beginning we should stick to the old theme for both modes. This topic has not been discussed with site owner yet, so we should work in the incremental steps on this.

Unfortunately it looks like the old theme (https://www.npmjs.com/package/prism-solarized-dark) need to be rewritten for the prism-react-renderer.

@darshkpatel
Copy link
Member

Yup, just noticed solarized-dark isn't present in https://github.com/FormidableLabs/prism-react-renderer/tree/master/src/themes

@Simek
Copy link
Author

Simek commented Sep 11, 2020

I have found out this yesterday during the work on #12 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants