Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix local build, basic theme overrides, header reorder, docusaurus bump #12

Merged
merged 12 commits into from
Sep 14, 2020

Conversation

Simek
Copy link

@Simek Simek commented Sep 10, 2020

This PR introduces the following changes:

  • adds basic theme overrides based on current RN website style
  • fixes local build:
    Screenshot 2020-09-10 194932
  • updates the BLM banner design and utilizes closeable property
  • bumps Docusaurus to the latest version

@slorber I'm open to any suggestion because I do not have big experience with V2 yet. I tried to uses as many CSS variables and config setting as possible, before introducing any custom additions. 🙂

Docusaurus TODOs regarding this changes

  • add style to the navbar config to allow force alsways 'dark' style (similar implementation to the footer component)
  • allow to specify to property in navbar items with items property
  • do not use horizontal or vertical variables for both directions, example (there are more occurrences of this practice):
    Screenshot 2020-09-10 214939
  • add missing custom CSS classes to the main theme elements, examples:
    • edit/last updated box
    • on page bottom nav (previous, next pages)
  • 🐛 ActivityIndicator page container shrinks too much because page do not have any full-width sentences/paragraphs.
  • 🐛 initial (first) TOC option is not selected correctly on page enter (user need to scroll the page to see the indicator)

Preview

Screenshot 2020-09-10 223709

@Simek Simek requested a review from slorber September 10, 2020 20:00
@Simek
Copy link
Author

Simek commented Sep 10, 2020

Copy link

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Simek Simek mentioned this pull request Sep 11, 2020
@Simek Simek merged commit f86a7aa into dev Sep 14, 2020
Simek added a commit that referenced this pull request Oct 20, 2020
…mp (#12)

* fix local build, basic theme overrides, header reorder, docusaurus bump

* add navbar override group, update navbar typography

* tweak version switcher and hr design

* update page links style, fix text color issues

* use docsVersionDropdown in navbar

* fix validation warning

* footer design tweaks, jsx as default prism language

* add native code banner, fix version label design, update notes style

* static dark navbar, color fix, docusaurus bump

* tweak dark theme, fix page shrinking issue

* navbar UI and positioning tweaks, update blog page

* sidebar spacing, minor color tweaks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants