This repository was archived by the owner on Dec 3, 2022. It is now read-only.
Bug/fix events #38
Merged
Bug/fix events #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 29, 2019
Closed
brentvatne
approved these changes
Aug 29, 2019
|
Thanks for the review 😊 will release tomorrow
Le jeu. 29 août 2019 à 21:09, Brent Vatne <notifications@github.com> a
écrit :
… ***@***.**** approved this pull request.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#38?email_source=notifications&email_token=AAFW6PUJ2K3GYR4GKZ47GL3QHANHFA5CNFSM4IR7RRL2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCDE6BEI#pullrequestreview-281665681>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAFW6PX6CRAN22GG6JEE3KDQHANHFANCNFSM4IR7RRLQ>
.
|
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix a few issues regarding the event system and focus:
@satya164 if you want to take a glance tell me, otherwise I'm going to merge and release anyway because I've tested this on my app and works fine and is actually usable, compared to former implementation which has a lot of problems.