Skip to content
This repository has been archived by the owner on Feb 8, 2020. It is now read-only.

feat: add dangerouslyGetParent #62

Merged
merged 3 commits into from
Aug 21, 2019
Merged

Conversation

osdnk
Copy link
Member

@osdnk osdnk commented Aug 21, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented Aug 21, 2019

Codecov Report

Merging #62 into master will decrease coverage by 0.32%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
- Coverage   92.41%   92.08%   -0.33%     
==========================================
  Files          27       27              
  Lines         501      493       -8     
  Branches      115      113       -2     
==========================================
- Hits          463      454       -9     
- Misses         33       34       +1     
  Partials        5        5
Impacted Files Coverage Δ
packages/core/src/useNavigationCache.tsx 100% <100%> (ø) ⬆️
...ges/core/src/__tests__/__fixtures__/MockRouter.tsx 84.84% <0%> (-3.04%) ⬇️
packages/core/src/NavigationContainer.tsx 88.05% <0%> (-0.35%) ⬇️
packages/core/src/useDevTools.tsx 57.14% <0%> (ø) ⬆️
packages/core/src/useNavigationHelpers.tsx 100% <0%> (ø) ⬆️
packages/core/src/useNavigationBuilder.tsx 100% <0%> (ø) ⬆️
packages/core/src/getStateFromPath.tsx 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4128654...3003642. Read the comment docs.

@@ -87,6 +91,13 @@ export default function useNavigationCache<
...rest,
...helpers,
...emitter.create(route.key),
dangerouslyGetParent: () =>
parentNavigation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be navigation, not parentNavigation. Reading the React navigation docs, this refers to the navigation object of the navigator.

@osdnk osdnk merged commit c0045d8 into master Aug 21, 2019
@osdnk osdnk deleted the @osdnk/dangerously-get-params branch August 21, 2019 11:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants