Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve the npm/yarn installation instruction #693

Merged
merged 2 commits into from
Feb 26, 2020

Conversation

eriveltonelias
Copy link
Member

Before:

Screen Shot 2020-02-26 at 09 09 52

After:

Screen Shot 2020-02-26 at 09 09 34

Copy link
Member

@satya164 satya164 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

--save is not necessary when running npm as it adds the dependency to package.json like yarn for a while now. Can you remove the addition of --save?

@eriveltonelias
Copy link
Member Author

--save is not necessary when running npm as it adds the dependency to package.json like yarn for a while now. Can you remove the addition of --save?

Yes, done :)

@satya164 satya164 merged commit e1fbbf5 into source Feb 26, 2020
@satya164 satya164 deleted the @eriveltonelias/bash branch February 26, 2020 16:41
@slorber
Copy link
Member

slorber commented Sep 28, 2020

FYE we may add this plugin to docusaurus repo: facebook/docusaurus#3469

@eriveltonelias
Copy link
Member Author

will be amazing @slorber, because right now we're using a copy/paste code from docusaurus core.

I just subscribed for this plugin PR and definitely, I want to import that from docusaurus when is available to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants