Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react-native-tab-view #366

Merged
merged 1 commit into from
Feb 17, 2017
Merged

Update react-native-tab-view #366

merged 1 commit into from
Feb 17, 2017

Conversation

satya164
Copy link
Member

@satya164 satya164 commented Feb 17, 2017

Fixes #209

Diff: satya164/react-native-tab-view@v0.0.55...v0.0.56
Release notes: https://github.com/react-native-community/react-native-tab-view/releases/tag/v0.0.56

Basically some fixes, accessibility support and added some tests.

Tested this on the playground app in simulator.

Copy link
Contributor

@ericvicenti ericvicenti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm assuming you tested on both platforms, you may want to mention that in your next test plan

@ericvicenti ericvicenti merged commit d6b5b28 into master Feb 17, 2017
@satya164 satya164 deleted the tab-view branch February 20, 2017 03:37
lintonye added a commit to lintonye/react-navigation that referenced this pull request Feb 22, 2017
* master: (55 commits)
  More gestures cleanup (react-navigation#353)
  CardStack: Don't overwrite custom transitionConfig with default (react-navigation#99)
  Update react-native-tab-view (react-navigation#366)
  Make future proof (and also fix it for the current beta) (react-navigation#322)
  Remove 'appBar' child component to fully support header styling (react-navigation#341)
  1.0.0-beta.5
  1.0.0-beta.4
  Update yarn.lock to include react 15.4.2
  Exported withNavigation to web (react-navigation#330)
  Overwrite 1x.ios as well
  Fix gesture recognition in card stack (react-navigation#324)
  Fix flow (react-navigation#305)
  adds button to photo screen (react-navigation#301)
  Add `showIcon` to `tabBarOptions` so that icons can be hidden on iOS (react-navigation#291)
  [FLOW] Fix missing "type" in flow import.
  Fix style prop for header
  Remove uncompleted sentence in Contributors guide. (react-navigation#280)
  Add missing characters to navigators api doc (react-navigation#264)
  Set numberOfLines to 1 for HeaderTitle (react-navigation#260)
  Add code sample for google analytics integration (react-navigation#107)
  ...
sourcecode911 pushed a commit to sourcecode911/react-navigation that referenced this pull request Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TabView - iOS bottom tabs can get pushed off screen
2 participants