Skip to content
This repository has been archived by the owner on Apr 12, 2021. It is now read-only.

Merge foliojs/master #8

Open
wants to merge 86 commits into
base: master
Choose a base branch
from

Conversation

maxaggedon
Copy link

This PR brings recent changes in the original repo in order to prevent performance issues with the older version from which this repo was forked. Especially it might be the source of a memory leak

This is work in progress

Tests do not pass on master so it makes it harder to know if the conflicts were correctly resolved.
A first commit contains all conflicts so it is possible to see how each conflict was resolved.

theBenForce and others added 30 commits June 22, 2018 17:54
Fix long-running loop
This can be caused by having text with a huge number of spaces.
This causes \n characters to be displayed more consistently.
Implement encryption and access privileges
Improve tests structure

    Load src files directly allowing to test without build step and test isolated classes
    Separate tests into two categories: unit and integration
    Allow to use ES modules in tests
    Ensure test output is the same across different runs / systems
liborm85 and others added 25 commits February 10, 2019 14:21
Use valueOf when converting String object values
Add changelog and improve Get Started document
Add standalone virtual file system implementation
Cleanup remaining artifacts from CoffeScript conversion
Update tests snapshots and cleanup cyrilic string in text test
@maxaggedon
Copy link
Author

maxaggedon commented Apr 10, 2019

I have been tracking down an error breaking tests, and have just realised that @react-pdf/fontkit will probably need to get updated as well...

@maxaggedon
Copy link
Author

@diegomura I opened another PR to merge upstream changes for fontkit. Same tests fail before and after. It seems to resolve some problems with glyphs. But there are still some broken tests (snapshots and LineWrapper) to investigate.

@ralphholzmann
Copy link

We've run into memory issues generating PDFs as well. Anything that can be done to help out here?

@maxaggedon
Copy link
Author

@ralphholzmann yes ! It would be great if you could test these changes and those in this PR with your codebase. I opened the PRs but I did not even get a chance to test it my self yet...

There is also a gist that should help determine if the memory leak is still present or not see this comment

If you have trouble setting up your project to test it, tell me.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.