Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure noindex urls are excluded from sitemap.xml #1620

Merged

Conversation

deiga
Copy link
Contributor

@deiga deiga commented Jun 10, 2021

Description

Setting noindex to true for a route should exclude it from the
sitemap, but this is not happening. There is a interface mismatch
between the state and how buildXML handles the option

Changes/Tasks

  • Changed code
  • Changed test
  • Added documentation

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Refactoring/add tests (refactoring or adding test which isn't a fix or add a feature)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have updated the documentation accordingly
  • I have updated the CHANGELOG with a summary of my changes
  • My changes have tests around them

deiga added 4 commits June 10, 2021 22:29
Signed-off-by: Timo Sand <tsd@amboss.com>
Signed-off-by: Timo Sand <tsd@amboss.com>
Signed-off-by: Timo Sand <tsd@amboss.com>
Signed-off-by: Timo Sand <tsd@amboss.com>
@SleeplessByte SleeplessByte merged commit 24f00c7 into react-static:master Jun 30, 2021
@deiga deiga deleted the fix-sitemap-ignoring-noindex-setting branch June 30, 2021 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants