Skip to content

Prevent error in destroyChart when chartInstance does not exist #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 26, 2020

Conversation

andreme
Copy link
Contributor

@andreme andreme commented Oct 28, 2019

I've seen error this error in my logs:

TypeError: Unable to get property 'config' of undefined or null reference
  at ChartComponent.prototype.destroyChart(/vendor.js:46065:21)
  at ChartComponent.prototype.componentWillUnmount(/vendor.js:46001:21)

There might be a different issue, but this seems like a safe fix.

@andreme
Copy link
Contributor Author

andreme commented Oct 28, 2019

This seems to be the root cause: chartjs/Chart.js#6630

@ichadw
Copy link

ichadw commented Jan 10, 2020

can @jerairrest merge this ? we need this to handle error on edge browser...

Co-Authored-By: Jeremy Ayerst <jeremyayerst@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants