Translate TextChannel#sendMessage to #send to fix deprecation warning #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes reactiflux#266, changing references to "sendMessage" to "send". It seems to work just fine with some brief testing and this reflects the fact the method seems to just be a passthrough: https://github.com/hydrabolt/discord.js/blob/11.1.0/src/structures/interfaces/TextBasedChannel.js#L415 This also changes the test stub "sendMessageStub" to be "sendStub" to reflect the name change.
Throne3d
force-pushed
the
fix/deprecation-sendmessage-send
branch
from
8b73d08 to
7f7505c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #266, changing references to "sendMessage" to "send". It seems to work just fine with some brief testing and this reflects the fact the method seems to just be a passthrough:
https://github.com/hydrabolt/discord.js/blob/11.1.0/src/structures/interfaces/TextBasedChannel.js#L415
This also changes the test stub "sendMessageStub" to be "sendStub" to reflect the name change.
… For some reason GitHub is telling me this can't automatically merge so I'm not sure if this is going to act weirdly when I create the PR.I had my master upstream set weirdly.This has been tested manually with:
ircStatusNoticesenabled(which should test each main path)