Add the ability to ignore IRC/Discord users by nickname #322
Conversation
lib/bot.js
Outdated
|
|
||
| // Discord nicks to ignore (case insensitive) | ||
| this.discordIgnoreUsers = options.discordIgnoreUsers || []; | ||
| this.discordIgnoreUsers = this.discordIgnoreUsers.map(x => x.toLowerCase()); |
There was a problem hiding this comment.
maybe just compare i.toLowerCase() === item.toLowerCase() instead of changing the array?
lib/bot.js
Outdated
| @@ -37,6 +41,14 @@ class Bot { | |||
| this.ircStatusNotices = options.ircStatusNotices; | |||
| this.announceSelfJoin = options.announceSelfJoin; | |||
|
|
|||
| // IRC nicks to ignore (case insensitive) | |||
| this.ircIgnoreUsers = options.ircIgnoreUsers || []; | |||
There was a problem hiding this comment.
could we change the config to be an object?
"igoreUsers": {
"irc": [],
"discord": [],
}
lib/bot.js
Outdated
| @@ -11,6 +11,10 @@ const NICK_COLORS = ['light_blue', 'dark_blue', 'light_red', 'dark_red', 'light_ | |||
| 'dark_green', 'magenta', 'light_magenta', 'orange', 'yellow', 'cyan', 'light_cyan']; | |||
| const patternMatch = /{\$(.+?)}/g; | |||
|
|
|||
| function caseInsensitiveExists(item, itemList) { | |||
| return itemList.some(i => i === item.toLowerCase()); | |||
There was a problem hiding this comment.
think you might as well inline this in ignoredIrcUser and ignoredDiscordUser - the extra layer of indirection probably just makes it harder to read
lib/bot.js
Outdated
| @@ -362,6 +387,11 @@ class Bot { | |||
| ircChannel: channel | |||
| }; | |||
|
|
|||
| // Do not send to Discord if this user is on the ignore list. | |||
| if (this.ignoredIrcUser(author)) { | |||
There was a problem hiding this comment.
maybe move this check to https://github.com/anirbanmu/discord-irc/blob/be281c5addff12a250866b351a05b91cb9d168e6/lib/bot.js#L377?
either in the same conditional or the line below - up to you
|
Other than the comments this looks good to me - thanks! |
|
Fixed everything regarding the comments. Please take another look when you have a chance! Thanks! @ekmartin |
|
Great - thanks! |
| @@ -90,6 +90,10 @@ First you need to create a Discord bot user, which you can do by following the i | |||
| // with one of these characters (commands): | |||
| "commandCharacters": ["!", "."], | |||
| "ircStatusNotices": true // Enables notifications in Discord when people join/part in the relevant IRC channel | |||
| @@ -90,6 +90,10 @@ First you need to create a Discord bot user, which you can do by following the i | |||
| // with one of these characters (commands): | |||
| "commandCharacters": ["!", "."], | |||
| "ircStatusNotices": true // Enables notifications in Discord when people join/part in the relevant IRC channel | |||
| "ignoreUsers": { | |||
| "irc": ["irc_nick1", "irc_nick2"] // Ignore specified IRC nicks and do not send their messages to Discord. | |||
This implements the simpler part of #236