Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run all test/*.test.js files #501

Merged
merged 1 commit into from
Aug 5, 2019
Merged

Conversation

Throne3d
Copy link
Collaborator

@Throne3d Throne3d commented Aug 5, 2019

Somehow, upgrading either mocha or nyc (?) appears to make the current test command skip test/bot-events.test.js. I do not know why, but quoting it (so mocha globs it instead) seems to fix this.

(This happened between 2.7.0 and 2.7.1.)

Somehow, upgrading either mocha or nyc (?) appears to make
the current test command skip test/bot-events.test.js.
I do not know why, but quoting it (so mocha globs it
instead) seems to fix this.

(This happened between 2.7.0 and 2.7.1.)
@coveralls
Copy link

Coverage Status

Coverage increased (+15.9%) to 97.159% when pulling 3c5a83a on Throne3d:fix/tests into 4196726 on reactiflux:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+15.9%) to 97.159% when pulling 3c5a83a on Throne3d:fix/tests into 4196726 on reactiflux:master.

@Throne3d
Copy link
Collaborator Author

Throne3d commented Aug 5, 2019

Coverage is nicely back to the high figure it was at before! I consider this a success. Merging.

@Throne3d Throne3d merged commit c9ccd7b into reactiflux:master Aug 5, 2019
@Throne3d Throne3d deleted the fix/tests branch August 5, 2019 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants